Skip to content

Commit ff2e619

Browse files
committed
[MC] Remove duplicate getFixupKindInfo calls. NFC
Due to 8728e09 (`std::unique_ptr<MCAsmBackend> Backend`), the compiler doesn't know that `Backend` will not be modified across function calls.
1 parent 435cb0d commit ff2e619

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

llvm/lib/MC/MCAssembler.cpp

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -167,18 +167,12 @@ bool MCAssembler::evaluateFixup(const MCFixup &Fixup, const MCFragment *DF,
167167
}
168168
}
169169

170-
assert(getBackendPtr() && "Expected assembler backend");
171-
bool IsTarget = getBackendPtr()->getFixupKindInfo(Fixup.getKind()).Flags &
172-
MCFixupKindInfo::FKF_IsTarget;
173-
174-
if (IsTarget)
170+
unsigned FixupFlags = getBackend().getFixupKindInfo(Fixup.getKind()).Flags;
171+
if (FixupFlags & MCFixupKindInfo::FKF_IsTarget)
175172
return getBackend().evaluateTargetFixup(*this, Fixup, DF, Target, STI,
176173
Value, WasForced);
177174

178-
unsigned FixupFlags = getBackendPtr()->getFixupKindInfo(Fixup.getKind()).Flags;
179-
bool IsPCRel = getBackendPtr()->getFixupKindInfo(Fixup.getKind()).Flags &
180-
MCFixupKindInfo::FKF_IsPCRel;
181-
175+
bool IsPCRel = FixupFlags & MCFixupKindInfo::FKF_IsPCRel;
182176
bool IsResolved = false;
183177
if (IsPCRel) {
184178
if (Target.getSymB()) {
@@ -213,8 +207,7 @@ bool MCAssembler::evaluateFixup(const MCFixup &Fixup, const MCFragment *DF,
213207
Value -= getSymbolOffset(Sym);
214208
}
215209

216-
bool ShouldAlignPC = getBackend().getFixupKindInfo(Fixup.getKind()).Flags &
217-
MCFixupKindInfo::FKF_IsAlignedDownTo32Bits;
210+
bool ShouldAlignPC = FixupFlags & MCFixupKindInfo::FKF_IsAlignedDownTo32Bits;
218211
assert((ShouldAlignPC ? IsPCRel : true) &&
219212
"FKF_IsAlignedDownTo32Bits is only allowed on PC-relative fixups!");
220213

0 commit comments

Comments
 (0)