Skip to content

Commit ff8aa30

Browse files
authored
[AMDGPU] Remove outdated COV6 warning (#132814)
1 parent 0aa4c35 commit ff8aa30

File tree

4 files changed

+1
-14
lines changed

4 files changed

+1
-14
lines changed

clang/include/clang/Basic/DiagnosticDriverKinds.td

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,6 @@ def err_drv_hipspv_no_hip_path : Error<
9292
"'--hip-path' must be specified when offloading to SPIR-V unless '-nogpuinc' "
9393
"is given">;
9494

95-
// TODO: Remove when COV6 is fully supported by ROCm.
96-
def warn_drv_amdgpu_cov6: Warning<
97-
"code object v6 is still in development and not ready for production use yet;"
98-
" use at your own risk">;
9995
def err_drv_undetermined_gpu_arch : Error<
10096
"cannot determine %0 architecture: %1; consider passing it via '%2'; "
10197
"environment variable CLANG_TOOLCHAIN_PROGRAM_TIMEOUT specifies the tool "

clang/lib/Driver/ToolChains/CommonArgs.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2748,12 +2748,6 @@ void tools::checkAMDGPUCodeObjectVersion(const Driver &D,
27482748
if (Remnant || CodeObjVer < MinCodeObjVer || CodeObjVer > MaxCodeObjVer)
27492749
D.Diag(diag::err_drv_invalid_int_value)
27502750
<< CodeObjArg->getAsString(Args) << CodeObjArg->getValue();
2751-
2752-
// COV6 is only supported by LLVM at the time of writing this, and it's
2753-
// expected to take some time before all ROCm components fully
2754-
// support it. In the meantime, make sure users are aware of this.
2755-
if (CodeObjVer == 6)
2756-
D.Diag(diag::warn_drv_amdgpu_cov6);
27572751
}
27582752
}
27592753
}

clang/test/Driver/hip-code-object-version.hip

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,10 @@
2727
// RUN: --offload-arch=gfx906 --rocm-path=%S/Inputs/rocm \
2828
// RUN: %s 2>&1 | FileCheck -check-prefix=V6 %s
2929

30-
// V6: warning: code object v6 is still in development and not ready for production use yet; use at your own risk
3130
// V6: "-mcode-object-version=6"
3231
// V6: "-mllvm" "--amdhsa-code-object-version=6"
3332
// V6: "-targets=host-x86_64-unknown-linux-gnu,hipv4-amdgcn-amd-amdhsa--gfx906"
3433

35-
3634
// Check bundle ID for code object version default
3735

3836
// RUN: %clang -### --target=x86_64-linux-gnu \

clang/test/Misc/warning-flags.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ This test serves two purposes:
1818

1919
The list of warnings below should NEVER grow. It should gradually shrink to 0.
2020

21-
CHECK: Warnings without flags (58):
21+
CHECK: Warnings without flags (57):
2222

2323
CHECK-NEXT: ext_expected_semi_decl_list
2424
CHECK-NEXT: ext_missing_whitespace_after_macro_name
@@ -40,7 +40,6 @@ CHECK-NEXT: warn_collection_expr_type
4040
CHECK-NEXT: warn_conflicting_variadic
4141
CHECK-NEXT: warn_delete_array_type
4242
CHECK-NEXT: warn_double_const_requires_fp64
43-
CHECK-NEXT: warn_drv_amdgpu_cov6
4443
CHECK-NEXT: warn_drv_assuming_mfloat_abi_is
4544
CHECK-NEXT: warn_drv_clang_unsupported
4645
CHECK-NEXT: warn_drv_pch_not_first_include

0 commit comments

Comments
 (0)