[SandboxIR] Implement PHINodes #101111
[SandboxIR] Implement PHINodes #101111
Conversation
This patch implements sandboxir::PHINode which mirrors llvm::PHINode. Based almost entirely on work by vporpo.
| @@ -1290,6 +1292,97 @@ class GetElementPtrInst final : public Instruction { | |||
| #endif | |||
| }; | |||
|
|
|||
| class PHINode final : public Instruction { | |||
| /// Use Context::createPHINode(). Don't call the | |||
There was a problem hiding this comment.
This comment looks like it should fit in a single 80-column line.
| /// constructor directly. | ||
| PHINode(llvm::PHINode *PHI, Context &Ctx) | ||
| : Instruction(ClassID::PHI, Opcode::PHI, PHI, Ctx) {} | ||
| friend Context; // for SBPHINode() |
| @@ -1301,6 +1407,11 @@ Context::createGetElementPtrInst(llvm::GetElementPtrInst *I) { | |||
| return cast<GetElementPtrInst>(registerValue(std::move(NewPtr))); | |||
| } | |||
|
|
|||
| PHINode *Context::createPHINode(llvm::PHINode *I) { | |||
| auto NewPtr = std::unique_ptr<PHINode>(new PHINode(I, *this)); | |||
| return cast<PHINode>(registerValue(std::move(NewPtr))); | |||
There was a problem hiding this comment.
nit: Perehaps return cast<PHINode>(registerValue(std::unique_ptr<PHINode>(new PHINode(I, *this)))); ?
There was a problem hiding this comment.
That ends up being different from the others, like on the code just above this one. Should we change them all?
There was a problem hiding this comment.
Sure, your call. Either is fine with me.
There was a problem hiding this comment.
I mean we can keep it as it is too, I don't feel strongly about changing them.
| return cast<llvm::PHINode>(Val)->hasConstantOrUndefValue(); | ||
| } | ||
| bool isComplete() const { return cast<llvm::PHINode>(Val)->isComplete(); } | ||
|
|
There was a problem hiding this comment.
Some member functions have not been implemented yet, like replaceIncomingBlockWith(), copyIncomingBlocks(), removeIncomingValueIf(). Could you add a TODO in the code ?
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
This patch implements sandboxir::PHINode which mirrors llvm::PHINode.
Based almost entirely on work by vporpo.