[compiler-rt] [Memprof] leave BufferedStackTrace uninit #102256
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
|
@llvm/pr-subscribers-pgo Author: Florian Mayer (fmayer) ChangesOtherwise we have to memset 2040 bytes (255 * 8) for each call Full diff: https://github.com/llvm/llvm-project/pull/102256.diff 1 Files Affected:
diff --git a/compiler-rt/lib/memprof/memprof_stack.h b/compiler-rt/lib/memprof/memprof_stack.h
index a8fdfc9def9d0..2a07019a71e5f 100644
--- a/compiler-rt/lib/memprof/memprof_stack.h
+++ b/compiler-rt/lib/memprof/memprof_stack.h
@@ -33,7 +33,7 @@ u32 GetMallocContextSize();
// don't want stack trace to contain functions from MemProf internals.
#define GET_STACK_TRACE(max_size, fast) \
- BufferedStackTrace stack; \
+ UNINITIALIZED BufferedStackTrace stack; \
if (max_size <= 2) { \
stack.size = max_size; \
if (max_size > 0) { \
|
fmayer
changed the base branch from
users/fmayer/spr/main.compiler-rt-memprof-leave-bufferedstacktrace-uninit
to
main
fmayer
changed the base branch from
main
to
users/fmayer/spr/main.compiler-rt-memprof-leave-bufferedstacktrace-uninit
vitalybuka
approved these changes
Aug 7, 2024
fmayer
added a commit
that referenced
this pull request
Aug 7, 2024
Otherwise we have to memset 2040 bytes (255 * 8) for each call Pull Request: #102256
fmayer
added a commit
to fmayer/llvm-project
that referenced
this pull request
Sep 13, 2024
Otherwise we have to memset 2040 bytes (255 * 8) for each call Pull Request: llvm#102256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we have to memset 2040 bytes (255 * 8) for each call