Skip to content

[NFC][TableGen] Simplify DirectiveEmitter using range for loops #107909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

jurahul
Copy link
Contributor

@jurahul jurahul commented Sep 9, 2024

Make constructors that take const Record * implicit, allowing us to simplify some range based loops to use that class instance as the loop variable.

Change remaining constructor calls to use () instead of {} to construct objects.

Make constructors that take const Record * implicit, allowing us to
simplify some range based loops to use that class instance as the loop
variable.

Change remaining constructor calls to use () instead of {} to construct
objects.
@jurahul jurahul changed the title [NFC][TableGen] Simplify DiretiveEmitter using range for loops [NFC][TableGen] Simplify DirectiveEmitter using range for loops Sep 9, 2024
Copy link
Contributor

@clementval clementval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jurahul jurahul marked this pull request as ready for review September 10, 2024 01:21
@jurahul
Copy link
Contributor Author

jurahul commented Sep 10, 2024

Thanks @clementval

@jurahul jurahul merged commit f7479b5 into llvm:main Sep 10, 2024
11 checks passed
@jurahul jurahul deleted the directive_emitter_loops branch September 10, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants