Skip to content

[CodeGen][MISched] Set DumpDirection after initPolicy #115112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

wangpc-pp
Copy link
Contributor

Previously we set the dump direction according to command line
options, but we may override the scheduling direction in initPolicy
and this results in mismatch between dump and actual policy.

Here we simply set the dump direction after initializing the policy.

Previously we set the dump direction according to command line
options, but we may override the scheduling direction in `initPolicy`
and this results in mismatch between dump and actual policy.

Here we simply set the dump direction after initializing the policy.
Copy link
Contributor

@michaelmaitland michaelmaitland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mshockwave mshockwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM good catch

@wangpc-pp wangpc-pp merged commit ee1608d into llvm:main Nov 8, 2024
8 checks passed
@wangpc-pp wangpc-pp deleted the main-scheduler-dump-direction branch November 8, 2024 03:46
Groverkss pushed a commit to iree-org/llvm-project that referenced this pull request Nov 15, 2024
Previously we set the dump direction according to command line
options, but we may override the scheduling direction in `initPolicy`
and this results in mismatch between dump and actual policy.

Here we simply set the dump direction after initializing the policy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants