Skip to content

[dsymutil] Add missing newlines in error messages. #115191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

rjmansfield
Copy link
Contributor

Errors like "cannot create bundle: Not a directory" or "error: a.out.dSYM: Is a directory" were being emitted without a newline.

@llvmbot
Copy link
Member

llvmbot commented Nov 6, 2024

@llvm/pr-subscribers-debuginfo

Author: Ryan Mansfield (rjmansfield)

Changes

Errors like "cannot create bundle: Not a directory" or "error: a.out.dSYM: Is a directory" were being emitted without a newline.


Full diff: https://github.com/llvm/llvm-project/pull/115191.diff

1 Files Affected:

  • (modified) llvm/tools/dsymutil/dsymutil.cpp (+2-2)
diff --git a/llvm/tools/dsymutil/dsymutil.cpp b/llvm/tools/dsymutil/dsymutil.cpp
index 754d3a0f26c3d1..2ace7180b00808 100644
--- a/llvm/tools/dsymutil/dsymutil.cpp
+++ b/llvm/tools/dsymutil/dsymutil.cpp
@@ -714,7 +714,7 @@ int dsymutil_main(int argc, char **argv, const llvm::ToolContext &) {
     Expected<OutputLocation> OutputLocationOrErr =
         getOutputFileName(InputFile, Options);
     if (!OutputLocationOrErr) {
-      WithColor::error() << toString(OutputLocationOrErr.takeError());
+      WithColor::error() << toString(OutputLocationOrErr.takeError()) << "\n";
       return EXIT_FAILURE;
     }
     Options.LinkOpts.ResourceDir = OutputLocationOrErr->getResourceDir();
@@ -792,7 +792,7 @@ int dsymutil_main(int argc, char **argv, const llvm::ToolContext &) {
               Options.LinkOpts.NoOutput ? "-" : OutputFile, EC,
               sys::fs::OF_None);
           if (EC) {
-            WithColor::error() << OutputFile << ": " << EC.message();
+            WithColor::error() << OutputFile << ": " << EC.message() << "\n";
             AllOK.fetch_and(false);
             return;
           }

@JDevlieghere JDevlieghere merged commit bbc3af0 into llvm:main Nov 6, 2024
10 checks passed
JDevlieghere pushed a commit to swiftlang/llvm-project that referenced this pull request Nov 7, 2024
Errors like "cannot create bundle: Not a directory" or "error:
a.out.dSYM: Is a directory" were being emitted without a newline.

(cherry picked from commit bbc3af0)
@rjmansfield rjmansfield deleted the dsym-newln-errors branch November 7, 2024 15:48
JDevlieghere added a commit to swiftlang/llvm-project that referenced this pull request Nov 7, 2024
[dsymutil] Add missing newlines in error messages. (llvm#115191)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants