[libc++] Amend error message for _LIBCPP_HAS_THREAD_API_EXTERNAL #115774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed this while debugging a few things following llvm#112094. Amended error message to reflect conditional check.
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Caslyn Tonelli (Caslyn) ChangesNoticed this while debugging a few things following #112094. Amended error message to reflect conditional check. Full diff: https://github.com/llvm/llvm-project/pull/115774.diff 1 Files Affected:
diff --git a/libcxx/include/__config b/libcxx/include/__config
index a2a1aa2b2978df..9db00cd0c9fb93 100644
--- a/libcxx/include/__config
+++ b/libcxx/include/__config
@@ -858,7 +858,7 @@ typedef __char32_t char32_t;
# endif
# if !_LIBCPP_HAS_THREADS && _LIBCPP_HAS_THREAD_API_EXTERNAL
-# error _LIBCPP_HAS_THREAD_API_EXTERNAL may not be true when _LIBCPP_HAS_THREADS is true.
+# error _LIBCPP_HAS_THREAD_API_EXTERNAL may only be true when _LIBCPP_HAS_THREADS is true.
# endif
# if !_LIBCPP_HAS_MONOTONIC_CLOCK && _LIBCPP_HAS_THREADS
|
philnik777
approved these changes
Nov 11, 2024
Groverkss
pushed a commit
to iree-org/llvm-project
that referenced
this pull request
Nov 15, 2024
…m#115774) Noticed this while debugging a few things following llvm#112094. Amended error message to reflect conditional check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this while debugging a few things following #112094. Amended error message to reflect conditional check.