Skip to content

[flang] Update CommandTest for AIX (NFC) #118403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2024
Merged

[flang] Update CommandTest for AIX (NFC) #118403

merged 1 commit into from
Dec 3, 2024

Conversation

kkwli
Copy link
Collaborator

@kkwli kkwli commented Dec 2, 2024

With the change in e335563, the behavior for ECLGeneralErrorCommandErrorSync on AIX is no longer different from that on Linux.

@kkwli kkwli self-assigned this Dec 2, 2024
@llvmbot llvmbot added the flang Flang issues not falling into any other category label Dec 2, 2024
DavidTruby
DavidTruby approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@DavidTruby DavidTruby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.
I'm not really sure why cmdStat is different on windows either, I found it difficult to find documentation that says what these values are actually supposed to be, and we're definitely not matching what they are in gfortran.

@kkwli
Copy link
Collaborator Author

kkwli commented Dec 3, 2024

LGTM, thanks. I'm not really sure why cmdStat is different on windows either, I found it difficult to find documentation that says what these values are actually supposed to be, and we're definitely not matching what they are in gfortran.

Thanks for the review.

@kkwli kkwli merged commit af35e21 into llvm:main Dec 3, 2024
10 checks passed
@kkwli kkwli deleted the fix-commandtest branch December 3, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidTruby DavidTruby DavidTruby approved these changes

@tblah tblah Awaiting requested review from tblah

@DanielCChen DanielCChen Awaiting requested review from DanielCChen

@yiwu0b11 yiwu0b11 Awaiting requested review from yiwu0b11

Assignees

@kkwli kkwli

Labels
flang Flang issues not falling into any other category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkwli @DavidTruby @llvmbot