-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[clang][Sema] Fix type of an statement expression ending with an atomic type #119711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cor3ntin
merged 11 commits into
llvm:main
from
alejandro-alvarez-sonarsource:aa/fix_gh106576
Feb 18, 2025
Merged
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d398fa1
Add regression test
alejandro-alvarez-sonarsource 296aa35
Tentative fix
alejandro-alvarez-sonarsource d13e109
Use PerformImplicitConversion
alejandro-alvarez-sonarsource 764c452
Merge branch 'main' into aa/fix_gh106576
alejandro-alvarez-sonarsource 02d8385
Add release note
alejandro-alvarez-sonarsource 62a63cc
Merge branch 'main' into aa/fix_gh106576
alejandro-alvarez-sonarsource f1b8d34
Merge branch 'main' into aa/fix_gh106576
alejandro-alvarez-sonarsource 2cfef98
Fix by using getAtomicUnqualifiedType
alejandro-alvarez-sonarsource 0c181e0
Merge remote-tracking branch 'upstream/main' into aa/fix_gh106576
alejandro-alvarez-sonarsource 87f6644
Update clang/docs/ReleaseNotes.rst
alejandro-alvarez-sonarsource 81e4efb
Remove duplicated typedef from test
alejandro-alvarez-sonarsource File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
// RUN: %clang_cc1 -fsyntax-only -verify %s | ||
|
||
typedef _Atomic char atomic_char; | ||
|
||
typedef _Atomic char atomic_char; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Presumably the redundant typedef is not a critical part of this test. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It isn't, I have removed the duplicated line. |
||
|
||
atomic_char counter; | ||
|
||
char load_plus_one(void) { | ||
return ({counter;}) + 1; // no crash | ||
} | ||
|
||
char type_of_stmt_expr(void) { | ||
typeof(({counter;})) y = ""; // expected-error-re {{incompatible pointer to integer conversion initializing 'typeof (({{{.*}}}))' (aka 'char') with an expression of type 'char[1]'}} | ||
return y; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.