MachineVerifier: Check stack protector is top-most in frame #121481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guy-david
force-pushed
the
users/guy-david/machine-stack-protector-offset
branch
2 times, most recently
from
b88ba09 to
2b6d2be
Compare
arsenm
reviewed
Jan 7, 2025
Mitigate against potential bugs that might place it elsewhere and render the mechanism useless.
guy-david
force-pushed
the
users/guy-david/machine-stack-protector-offset
branch
from
2b6d2be to
9c7f9ab
Compare
arsenm
approved these changes
Jan 10, 2025
|
@guy-david This is causing build failures on EXPENSIVE_CHECKS builds, I'm going to revert for now - please can you investigate? |
RKSimon
added a commit
that referenced
this pull request
Jan 10, 2025
… frame" (#122444) Reverts #121481 This is causing build failures on EXPENSIVE_CHECKS builds: https://lab.llvm.org/buildbot/#/builders/187/builds/3653 https://lab.llvm.org/buildbot/#/builders/16/builds/11758
github-actions bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Jan 10, 2025
…top-most in frame" (#122444) Reverts llvm/llvm-project#121481 This is causing build failures on EXPENSIVE_CHECKS builds: https://lab.llvm.org/buildbot/#/builders/187/builds/3653 https://lab.llvm.org/buildbot/#/builders/16/builds/11758
BaiXilin
pushed a commit
to BaiXilin/llvm-fix-vnni-instr-types
that referenced
this pull request
Jan 12, 2025
BaiXilin
pushed a commit
to BaiXilin/llvm-fix-vnni-instr-types
that referenced
this pull request
Jan 12, 2025
… frame" (llvm#122444) Reverts llvm#121481 This is causing build failures on EXPENSIVE_CHECKS builds: https://lab.llvm.org/buildbot/#/builders/187/builds/3653 https://lab.llvm.org/buildbot/#/builders/16/builds/11758
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat paranoid, but mitigates potential bugs in the future that might place it elsewhere and render the mechanism useless.