-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[Flang][OpenMP]Add parsing support for DISPATCH construct #121982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
! RUN: %not_todo_cmd %flang_fc1 -emit-fir -fopenmp -fopenmp-version=51 -o - %s 2>&1 | FileCheck %s | ||
|
||
! CHECK: not yet implemented: OpenMPDispatchConstruct | ||
program p | ||
integer r | ||
r = 1 | ||
!$omp dispatch nowait | ||
call foo() | ||
contains | ||
subroutine foo | ||
end subroutine | ||
end program p |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
! RUN: %flang_fc1 -fopenmp -fdebug-dump-parse-tree %s | FileCheck %s | ||
! RUN: %flang_fc1 -fopenmp -fdebug-unparse %s | FileCheck %s --check-prefix="UNPARSE" | ||
|
||
integer function func(a, b, c) | ||
integer :: a, b, c | ||
func = a + b + c | ||
end function func | ||
|
||
subroutine sub(x) | ||
use iso_c_binding | ||
integer :: func | ||
integer :: r | ||
type(c_ptr) :: x | ||
integer :: a = 14, b = 7, c = 21 | ||
!UNPARSE: !$OMP DISPATCH DEVICE(3_4) NOWAIT NOCONTEXT(.false._4) NOVARIANTS(.true._4) | ||
!CHECK: | | ExecutionPartConstruct -> ExecutableConstruct -> OpenMPConstruct -> OpenMPDispatchConstruct | ||
!CHECK-NEXT: | | | OmpDispatchDirective | ||
!CHECK: | | | | OmpClauseList -> OmpClause -> Device -> OmpDeviceClause | ||
!CHECK-NEXT: | | | | | Scalar -> Integer -> Expr = '3_4' | ||
!CHECK-NEXT: | | | | | | LiteralConstant -> IntLiteralConstant = '3' | ||
!CHECK-NEXT: | | | | OmpClause -> Nowait | ||
!CHECK-NEXT: | | | | OmpClause -> Nocontext -> Scalar -> Logical -> Expr = '.false._4' | ||
!CHECK-NEXT: | | | | | LiteralConstant -> LogicalLiteralConstant | ||
!CHECK-NEXT: | | | | | | bool = 'false' | ||
!CHECK-NEXT: | | | | OmpClause -> Novariants -> Scalar -> Logical -> Expr = '.true._4' | ||
!CHECK-NEXT: | | | | | EQ | ||
!CHECK-NEXT: | | | | | | Expr = '1_4' | ||
!CHECK-NEXT: | | | | | | | LiteralConstant -> IntLiteralConstant = '1' | ||
!CHECK-NEXT: | | | | | | Expr = '1_4' | ||
!CHECK-NEXT: | | | | | | | LiteralConstant -> IntLiteralConstant = '1' | ||
!CHECK-NEXT: | | | Block | ||
|
||
!$omp dispatch device(3) nowait nocontext(.false.) novariants(1.eq.1) | ||
r = func(a, b, c) | ||
!UNPARSE: !$OMP END DISPATCH | ||
!CHECK: | | | OmpEndDispatchDirective | ||
!$omp end dispatch | ||
|
||
!! Test the "no end dispatch" option. | ||
!UNPARSE: !$OMP DISPATCH DEVICE(3_4) IS_DEVICE_PTR(x) | ||
!CHECK: | | ExecutionPartConstruct -> ExecutableConstruct -> OpenMPConstruct -> OpenMPDispatchConstruct | ||
!CHECK-NEXT: | | | OmpDispatchDirective | ||
!CHECK: | | | | OmpClause -> IsDevicePtr -> OmpObjectList -> OmpObject -> Designator -> DataRef -> Name = 'x' | ||
!$omp dispatch device(3) is_device_ptr(x) | ||
r = func(a+1, b+2, c+3) | ||
!CHECK-NOT: | | | OmpEndDispatchDirective | ||
|
||
end subroutine sub | ||
|
||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
! RUN: %python %S/../test_errors.py %s %flang -fopenmp | ||
|
||
subroutine sb1 | ||
integer :: r | ||
r = 1 | ||
!ERROR: The DISPATCH construct does not contain a SUBROUTINE or FUNCTION | ||
!$omp dispatch nowait | ||
print *,r | ||
end subroutine | ||
subroutine sb2 | ||
integer :: r | ||
!ERROR: The DISPATCH construct is empty or contains more than one statement | ||
!$omp dispatch | ||
call foo() | ||
r = bar() | ||
!$omp end dispatch | ||
contains | ||
subroutine foo | ||
end subroutine foo | ||
function bar | ||
integer :: bar | ||
bar = 2 | ||
end function | ||
end subroutine |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a check that the "block" is a single function/procedure call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.