[llvm-profdata] XFAIL broken test on windows #124165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-pgo Author: Ellis Hoag (ellishg) ChangesXFAIL Full diff: https://github.com/llvm/llvm-project/pull/124165.diff 1 Files Affected:
diff --git a/llvm/test/tools/llvm-profdata/general.proftext b/llvm/test/tools/llvm-profdata/general.proftext
index 89762f2540f6a6..ca532f9a37116d 100644
--- a/llvm/test/tools/llvm-profdata/general.proftext
+++ b/llvm/test/tools/llvm-profdata/general.proftext
@@ -1,3 +1,5 @@
+# FIXME: Somehow this is failing on windows after https://github.com/llvm/llvm-project/pull/105915
+# XFAIL: system-windows
# RUN: llvm-profdata merge -sparse=true %s -o %t.profdata
# RUN: llvm-profdata merge -sparse=false %s -o %t.profdata.dense
|
This was referenced Jan 23, 2025
github-actions bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Jan 23, 2025
…24169) The detailed summary format was changed in llvm/llvm-project#105915 which broke `llvm/test/tools/llvm-profdata/general.proftext` (XFAILed in llvm/llvm-project#124165). Apparently the behavior of `%lu` is different between Linux and Windows, so I reverted back to using `<<` style formats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XFAIL
llvm/test/tools/llvm-profdata/general.proftextafter it was accidentally broken by #105915. I will follow up to get this fixed.