Skip to content

[lldb] Document lldb x packet deprecation. #125682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025
Merged

[lldb] Document lldb x packet deprecation. #125682

merged 1 commit into from
Feb 5, 2025

Conversation

labath
Copy link
Collaborator

@labath labath commented Feb 4, 2025

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Feb 4, 2025

@llvm/pr-subscribers-lldb

Author: Pavel Labath (labath)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/125682.diff

1 Files Affected:

  • (modified) lldb/docs/resources/lldbgdbremote.md (+5)
diff --git a/lldb/docs/resources/lldbgdbremote.md b/lldb/docs/resources/lldbgdbremote.md
index 5cac3736337a8f..162815148a18bf 100644
--- a/lldb/docs/resources/lldbgdbremote.md
+++ b/lldb/docs/resources/lldbgdbremote.md
@@ -2412,6 +2412,11 @@ value of errno if unlink failed.
 
 ## "x" - Binary memory read
 
+> **Warning:** The format of this packet was decided before GDB 16
+> introduced its own format for `x`. Future versions of LLDB may not
+> support the format described here, and new code should produce and
+> expect the format used by GDB.
+
 Like the `m` (read) and `M` (write) packets, this is a partner to the
 `X` (write binary data) packet, `x`.
 

Copy link
Collaborator

@DavidSpickett DavidSpickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavidSpickett DavidSpickett changed the title Document lldb x packet deprecation. [lldb] Document lldb x packet deprecation. Feb 4, 2025
@labath labath merged commit ad38c4c into main Feb 5, 2025
10 checks passed
@labath labath deleted the users/labath/x-doc branch February 5, 2025 08:26
Icohedron pushed a commit to Icohedron/llvm-project that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants