release/20.x: [libc++][ci] Update the Windows toolchains to Clang 19 (#129232) #129303
Conversation
|
@frederick-vs-ja What do you think about merging this PR to the release branch? |
llvmbot
added
libc++
|
@llvm/pr-subscribers-github-workflow @llvm/pr-subscribers-libcxx Author: None (llvmbot) ChangesBackport e6a0ee3 Requested by: @mstorsjo Full diff: https://github.com/llvm/llvm-project/pull/129303.diff 1 Files Affected:
diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index ee77e83363d37..3346c1322a07c 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -251,11 +251,11 @@ jobs:
- name: Install a current LLVM
if: ${{ matrix.mingw != true }}
run: |
- choco install -y llvm --version=18.1.6 --allow-downgrade
+ choco install -y llvm --version=19.1.7 --allow-downgrade
- name: Install llvm-mingw
if: ${{ matrix.mingw == true }}
run: |
- curl -LO https://github.com/mstorsjo/llvm-mingw/releases/download/20240606/llvm-mingw-20240606-ucrt-x86_64.zip
+ curl -LO https://github.com/mstorsjo/llvm-mingw/releases/download/20250114/llvm-mingw-20250114-ucrt-x86_64.zip
powershell Expand-Archive llvm-mingw*.zip -DestinationPath .
del llvm-mingw*.zip
mv llvm-mingw* c:\llvm-mingw
|
I think @ldionne or @philnik777 should reply here. Without this, I guess the clang-cl CI configs will fail on the 20.x release branch. |
github-project-automation
bot
moved this from Needs Triage
to Needs Merge
in LLVM Release Status
|
Does this need to be in 20.1.0 or could it wait until 20.1.1 ? |
The libcxx CI gets failures in the clang-cl configs on Windows, which this fixes. So this change isn't urgent in itself, but if the libcxx CI is run on the release branch, it'll have unrelated errors until this is merged. |
This also fixes test failures in the clang-cl build configs that started a couple days ago. It seems like the failures were triggered by an update to the base image on the Github provided runners. There were failures in test/libcxx/system_reserved_names.gen.py, due to an issue in an Clang intrinsics header (avx512fp16intrin.h); this issue was observed and fixed for Clang 19 in 6f04f46. The test does #define A SYSTEM_RESERVED_NAME which clashes with a parameter with the name `A` in that header. By upgrading the toolchain to Clang 19, we get fixed version of this intrinsics header. Also update the llvm-mingw toolchains to a version with Clang 19.1.7. (cherry picked from commit e6a0ee3)
github-project-automation
bot
moved this from Needs Merge
to Done
in LLVM Release Status
|
@mstorsjo (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR. |
Backport e6a0ee3
Requested by: @mstorsjo