Skip to content

[libc][math] Add missing parenthesis in sollya command #132298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

krishna2803
Copy link
Contributor

This PR adds the missing opening parenthesis for sollya command comment in libc/src/math/generic/cbrtf.cpp#L28.

@llvmbot llvmbot added the libc label Mar 20, 2025
@krishna2803
Copy link
Contributor Author

@lntue

@llvmbot
Copy link
Member

llvmbot commented Mar 20, 2025

@llvm/pr-subscribers-libc

Author: Krishna Pandey (krishna2803)

Changes

This PR adds the missing opening parenthesis for sollya command comment in libc/src/math/generic/cbrtf.cpp#L28.


Full diff: https://github.com/llvm/llvm-project/pull/132298.diff

1 Files Affected:

  • (modified) libc/src/math/generic/cbrtf.cpp (+1-1)
diff --git a/libc/src/math/generic/cbrtf.cpp b/libc/src/math/generic/cbrtf.cpp
index 0abbf6e879421..71b23c4a8c742 100644
--- a/libc/src/math/generic/cbrtf.cpp
+++ b/libc/src/math/generic/cbrtf.cpp
@@ -25,7 +25,7 @@ constexpr double CBRT2[3] = {1.0, 0x1.428a2f98d728bp0, 0x1.965fea53d6e3dp0};
 // Degree-7 polynomials approximation of ((1 + x)^(1/3) - 1)/x for 0 <= x <= 1
 // generated by Sollya with:
 // > for i from 0 to 15 do {
-//     P = fpminimax((1 + x)^(1/3) - 1)/x, 6, [|D...|], [i/16, (i + 1)/16]);
+//     P = fpminimax(((1 + x)^(1/3) - 1)/x, 6, [|D...|], [i/16, (i + 1)/16]);
 //     print("{", coeff(P, 0), ",", coeff(P, 1), ",", coeff(P, 2), ",",
 //           coeff(P, 3), ",", coeff(P, 4), ",", coeff(P, 5), ",",
 //           coeff(P, 6), "},");

@lntue lntue merged commit 9020783 into llvm:main Mar 21, 2025
16 of 17 checks passed
@krishna2803 krishna2803 deleted the sollya branch March 21, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants