Skip to content

workflows: Add missing apt-get update to abi tests #133264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

tstellar
Copy link
Collaborator

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Mar 27, 2025

@llvm/pr-subscribers-github-workflow

Author: Tom Stellard (tstellar)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/133264.diff

2 Files Affected:

  • (modified) .github/workflows/libclang-abi-tests.yml (+4-1)
  • (modified) .github/workflows/llvm-tests.yml (+4-1)
diff --git a/.github/workflows/libclang-abi-tests.yml b/.github/workflows/libclang-abi-tests.yml
index 440af1691deed..27cb7c4f75513 100644
--- a/.github/workflows/libclang-abi-tests.yml
+++ b/.github/workflows/libclang-abi-tests.yml
@@ -103,6 +103,7 @@ jobs:
         uses: llvm/actions/install-ninja@main
       - name: Install abi-compliance-checker
         run: |
+          sudo apt-get update
           sudo apt-get install abi-dumper autoconf pkg-config
       - name: Install universal-ctags
         run: |
@@ -154,7 +155,9 @@ jobs:
           path: build-latest
 
       - name: Install abi-compliance-checker
-        run: sudo apt-get install abi-compliance-checker
+        run: |
+          sudo apt-get update
+          sudo apt-get install abi-compliance-checker
       - name: Compare ABI
         run: |
           for lib in ${{ needs.abi-dump-setup.outputs.ABI_LIBS }}; do
diff --git a/.github/workflows/llvm-tests.yml b/.github/workflows/llvm-tests.yml
index 464b4c726b966..3b44ef6dca502 100644
--- a/.github/workflows/llvm-tests.yml
+++ b/.github/workflows/llvm-tests.yml
@@ -91,6 +91,7 @@ jobs:
         uses: llvm/actions/install-ninja@main
       - name: Install abi-compliance-checker
         run: |
+          sudo apt-get update
           sudo apt-get install abi-dumper autoconf pkg-config
       - name: Install universal-ctags
         run: |
@@ -163,7 +164,9 @@ jobs:
           path: symbol-list
 
       - name: Install abi-compliance-checker
-        run: sudo apt-get install abi-compliance-checker
+        run: |
+          sudo apt-get update
+          sudo apt-get install abi-compliance-checker
       - name: Compare ABI
         run: |
           if [ -s symbol-list/llvm.symbols ]; then

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for missing this. Transitive deps always seem to bite somewhere...

@tstellar
Copy link
Collaborator Author

LGTM. Sorry for missing this. Transitive deps always seem to bite somewhere...

I don't think you broke this. It stopped working in the release branch.

@tstellar tstellar merged commit a10a913 into llvm:main Mar 27, 2025
11 checks passed
@tstellar tstellar added this to the LLVM 20.X Release milestone Mar 27, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Mar 27, 2025
@tstellar
Copy link
Collaborator Author

/cherry-pick a10a913

@llvmbot
Copy link
Member

llvmbot commented Mar 27, 2025

/pull-request #133336

@llvmbot llvmbot moved this from Needs Triage to Done in LLVM Release Status Mar 27, 2025
Kosm8 pushed a commit to Kosm8/llvm-project that referenced this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants