[lldb/Format] Make progress count show thousands separators (NFC) #137446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes the progress count formatting show thousands separator making it easier to read big numbers. Signed-off-by: Med Ismail Bennani <[email protected]>
|
@llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) ChangesThis patch changes the progress count formatting show thousands separator making it easier to read big numbers. Full diff: https://github.com/llvm/llvm-project/pull/137446.diff 1 Files Affected:
diff --git a/lldb/source/Core/FormatEntity.cpp b/lldb/source/Core/FormatEntity.cpp
index e352d07fe487d..6cdfcfedf8be5 100644
--- a/lldb/source/Core/FormatEntity.cpp
+++ b/lldb/source/Core/FormatEntity.cpp
@@ -1959,7 +1959,7 @@ bool FormatEntity::Format(const Entry &entry, Stream &s,
if (Target *target = Target::GetTargetFromContexts(exe_ctx, sc)) {
if (auto progress = target->GetDebugger().GetCurrentProgressReport()) {
if (progress->total != UINT64_MAX) {
- s.Format("[{0}/{1}]", progress->completed, progress->total);
+ s.Format("[{0:N}/{1:N}]", progress->completed, progress->total);
return true;
}
}
|
medismailben
added a commit
to medismailben/llvm-project
that referenced
this pull request
Apr 28, 2025
…vm#137446) This patch changes the progress count formatting show thousands separator making it easier to read big numbers. Signed-off-by: Med Ismail Bennani <[email protected]> (cherry picked from commit 4e4c6d7) (cherry picked from commit 692aa54741db46fb224d5fffd231e98997b85f76)
medismailben
added a commit
to medismailben/llvm-project
that referenced
this pull request
Apr 28, 2025
…vm#137446) This patch changes the progress count formatting show thousands separator making it easier to read big numbers. Signed-off-by: Med Ismail Bennani <[email protected]> (cherry picked from commit 4e4c6d7)
JDevlieghere
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Apr 29, 2025
[lldb/Format] Make progress count show thousands separators (NFC) (llvm#137446)
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…vm#137446) This patch changes the progress count formatting show thousands separator making it easier to read big numbers. Signed-off-by: Med Ismail Bennani <[email protected]>
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…vm#137446) This patch changes the progress count formatting show thousands separator making it easier to read big numbers. Signed-off-by: Med Ismail Bennani <[email protected]>
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…vm#137446) This patch changes the progress count formatting show thousands separator making it easier to read big numbers. Signed-off-by: Med Ismail Bennani <[email protected]>
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
…vm#137446) This patch changes the progress count formatting show thousands separator making it easier to read big numbers. Signed-off-by: Med Ismail Bennani <[email protected]>
Ankur-0429
pushed a commit
to Ankur-0429/llvm-project
that referenced
this pull request
May 9, 2025
…vm#137446) This patch changes the progress count formatting show thousands separator making it easier to read big numbers. Signed-off-by: Med Ismail Bennani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the progress count formatting show thousands separator making it easier to read big numbers.