Skip to content

Skip contiguous check when ignore_tkr(c) is used #138762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion flang/lib/Semantics/check-call.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1016,7 +1016,8 @@ static void CheckExplicitDataArg(const characteristics::DummyDataObject &dummy,
}
}
if (dummyDataAttr == common::CUDADataAttr::Device &&
(dummyIsAssumedShape || dummyIsAssumedRank)) {
(dummyIsAssumedShape || dummyIsAssumedRank) &&
!dummy.ignoreTKR.test(common::IgnoreTKR::Contiguous)) {
if (auto contig{evaluate::IsContiguous(actual, foldingContext,
/*namedConstantSectionsAreContiguous=*/true,
/*firstDimensionStride1=*/true)}) {
Expand Down
42 changes: 42 additions & 0 deletions flang/test/Semantics/cuf20.cuf
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
! RUN: %python %S/test_errors.py %s %flang_fc1

! Test case 1: Device arrays with ignore_tkr(c)
subroutine test_device_arrays()
interface bar
subroutine bar1(a)
!dir$ ignore_tkr(c) a
real :: a(..)
!@cuf attributes(device) :: a
end subroutine
end interface

integer :: n = 10, k = 2
real, device :: a(10), b(10), c(10)

call bar(a(1:n)) ! Should not warn about contiguity
call bar(b(1:n:k)) ! Should not warn about contiguity
call bar(c(1:n:2)) ! Should not warn about contiguity
end subroutine

! Test case 2: Managed arrays with ignore_tkr(c)
subroutine test_managed_arrays()
interface bar
subroutine bar1(a)
!dir$ ignore_tkr(c) a
real :: a(..)
!@cuf attributes(device) :: a
end subroutine
end interface

integer :: n = 10, k = 2
real, managed :: a(10), b(10), c(10)

call bar(a(1:n)) ! Should not warn about contiguity
call bar(b(1:n:k)) ! Should not warn about contiguity
call bar(c(1:n:2)) ! Should not warn about contiguity
end subroutine

program main
call test_device_arrays()
call test_managed_arrays()
end program
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line at end of line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strangely I don't see new line after end program in the source code.

Loading