Skip to content

[clang-tools-extra] Use llvm::max_element (NFC) #140458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kazutakahirata
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented May 18, 2025

@llvm/pr-subscribers-clang-tools-extra

@llvm/pr-subscribers-clang-tidy

Author: Kazu Hirata (kazutakahirata)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/140458.diff

2 Files Affected:

  • (modified) clang-tools-extra/clang-tidy/misc/ConfusableTable/BuildConfusableTable.cpp (+3-5)
  • (modified) clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp (+4-5)
diff --git a/clang-tools-extra/clang-tidy/misc/ConfusableTable/BuildConfusableTable.cpp b/clang-tools-extra/clang-tidy/misc/ConfusableTable/BuildConfusableTable.cpp
index 57190942a1756..18ac7e508165b 100644
--- a/clang-tools-extra/clang-tidy/misc/ConfusableTable/BuildConfusableTable.cpp
+++ b/clang-tools-extra/clang-tidy/misc/ConfusableTable/BuildConfusableTable.cpp
@@ -57,11 +57,9 @@ int main(int argc, char *argv[]) {
   llvm::sort(Entries);
 
   unsigned LargestValue =
-      std::max_element(Entries.begin(), Entries.end(),
-                       [](const auto &Entry0, const auto &Entry1) {
-                         return Entry0.second.size() < Entry1.second.size();
-                       })
-          ->second.size();
+      llvm::max_element(Entries, [](const auto &Entry0, const auto &Entry1) {
+        return Entry0.second.size() < Entry1.second.size();
+      })->second.size();
 
   std::error_code Ec;
   llvm::raw_fd_ostream Os(argv[2], Ec);
diff --git a/clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp b/clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp
index 51ee35da623f2..bb06f7ff71d8f 100644
--- a/clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp
+++ b/clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp
@@ -333,11 +333,10 @@ static void addPlaceholderArgs(const LambdaProperties &LP,
 
   ArrayRef<BindArgument> Args = LP.BindArguments;
 
-  const auto *MaxPlaceholderIt =
-      std::max_element(Args.begin(), Args.end(),
-                       [](const BindArgument &B1, const BindArgument &B2) {
-                         return B1.PlaceHolderIndex < B2.PlaceHolderIndex;
-                       });
+  const auto *MaxPlaceholderIt = llvm::max_element(
+      Args, [](const BindArgument &B1, const BindArgument &B2) {
+        return B1.PlaceHolderIndex < B2.PlaceHolderIndex;
+      });
 
   // Placeholders (if present) have index 1 or greater.
   if (!PermissiveParameterList && (MaxPlaceholderIt == Args.end() ||

@kazutakahirata kazutakahirata merged commit 9384e8e into llvm:main May 18, 2025
14 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_001_range_llvm_max_element_clang_tools branch May 18, 2025 16:46
ajaden-codes pushed a commit to Jaddyen/llvm-project that referenced this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants