Skip to content

release/20.x: [libclc] Include isnan implementation for SPIR-V targets #140902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

karolherbst
Copy link

@karolherbst karolherbst commented May 21, 2025

The fma software emulation requires it.

Similar to #124614

This change intentionally targets 20.x as things changed on main enough that it's not feasible to land a change in main first.

Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@karolherbst karolherbst force-pushed the libclc/isnan_spirv branch from 2bf0c71 to d8ad1f5 Compare May 21, 2025 14:10
@karolherbst karolherbst changed the title [libclc] Include isnan implementation for SPIR-V targets release/20.x: [libclc] Include isnan implementation for SPIR-V targets May 21, 2025
@karolherbst karolherbst force-pushed the libclc/isnan_spirv branch from d8ad1f5 to 19163b4 Compare May 22, 2025 17:27
@nikic nikic requested a review from frasercrmck May 24, 2025 18:51
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status May 24, 2025
@nikic nikic added this to the LLVM 20.X Release milestone May 24, 2025
@tstellar tstellar moved this from Needs Triage to Needs Review in LLVM Release Status May 25, 2025
@github-project-automation github-project-automation bot moved this from Needs Review to Needs Merge in LLVM Release Status May 26, 2025
The fma software emulation requires it.

Similar to llvm#124614
@tstellar tstellar force-pushed the libclc/isnan_spirv branch from 19163b4 to 47addd4 Compare May 27, 2025 22:34
@tstellar tstellar merged commit 47addd4 into llvm:release/20.x May 27, 2025
4 of 5 checks passed
@github-project-automation github-project-automation bot moved this from Needs Merge to Done in LLVM Release Status May 27, 2025
Copy link

@karolherbst Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

Copy link

@karolherbst (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants