[libc++] Update GDB pretty-printer to work with GDB 17 #142106
Conversation
Fixed an issue in `libcxx/utils/gdb/libcxx/printers.py`. With gdb 17 (binutils 2_44) pretty-printers do not work anymore because calls to `gdb.printing` require `import gdb.printing` statement, which was missing from the printers.py Broken after commit bminor/binutils-gdb@fc14343, and `importgdb.printing` was first referenced in bminor/binutils-gdb@ee06c79
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: kotborealis (kotborealis) ChangesFixed an issue in With gdb 17 (binutils 2_44) pretty-printers do not work anymore because calls to Broken after commit binutils-gdb/fc14343205d3a68db1fc139e4af9796be208fab4, and Full diff: https://github.com/llvm/llvm-project/pull/142106.diff 1 Files Affected:
diff --git a/libcxx/utils/gdb/libcxx/printers.py b/libcxx/utils/gdb/libcxx/printers.py
index e3d5d87aca325..90bc54d987ee8 100644
--- a/libcxx/utils/gdb/libcxx/printers.py
+++ b/libcxx/utils/gdb/libcxx/printers.py
@@ -14,6 +14,7 @@
import re
import gdb
+import gdb.printing
# One under-documented feature of the gdb pretty-printer API
# is that clients can call any other member of the API
|
ldionne
changed the title
|
The branch was updated to pass CI which had infrastructural errors |
Yeah, we're having a lot of infra issues. If it fails again, don't do anything, I'll restart just the jobs that failed. |
|
@ldionne could you please rerun 4 failed jobs? |
Done. Apologies, our CI is a real pain right now. |
|
Actually, I think this has passed the necessary CI. I'm merging this. Thanks for the fix! |
|
@kotborealis Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
This patch fixes an issue in libcxx/utils/gdb/libcxx/printers.py. With gdb 17 (binutils 2_44) pretty-printers do not work anymore because calls to `gdb.printing` requires `import gdb.printing` statement, which was missing from the `printers.py`. This was broken after commit bminor/binutils-gdb@fc14343205d3a and `import gdb.printing` was first referenced in bminor/binutils-gdb@ee06c79b0f. Co-authored-by: Dmitry Chestnykh <[email protected]>
|
Hi, I experienced a similar issue with So "technically", not GDB 17 issue. Thanks for the fix! @ldionne , is it possible to cherry-pick this change to LLVM-20? |
This patch fixes an issue in libcxx/utils/gdb/libcxx/printers.py. With gdb 17 (binutils 2_44) pretty-printers do not work anymore because calls to `gdb.printing` requires `import gdb.printing` statement, which was missing from the `printers.py`. This was broken after commit bminor/binutils-gdb@fc14343205d3a and `import gdb.printing` was first referenced in bminor/binutils-gdb@ee06c79b0f. Co-authored-by: Dmitry Chestnykh <[email protected]>
Fixed an issue in
libcxx/utils/gdb/libcxx/printers.py.With gdb 17 (binutils 2_44) pretty-printers do not work anymore because calls to
gdb.printingrequiresimport gdb.printingstatement, which was missing from theprinters.py.Broken after commit binutils-gdb/fc14343205d3a68db1fc139e4af9796be208fab4, and
import gdb.printingwas first referenced in binutils-gdb/ee06c79b0fefd5e4ed5e7a1171dc3440130e41da