[CodeGen][LTO] Rename some misleading variables #65185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some flags named "IsLTO" and "IsThinLTO" implied they described compilation modes, but with Unified LTO this is no longer true. Rename these to "PrepForXXX" to be less confusing to readers. Also, deleted "IsThinOrUnifiedLTO" because Unified implies PrepareForThinLTO.
ilovepi
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
I think this is fine from my perspective. I just tried to translate the existing logic a bit to work w/ the FatLTO pipeline, so if these names will improve clarity, I'm all for it.
I see that we set PrepareForThinLTO w/ -funified-lto in CompilerInvocation.cpp so I assume that will be safe, but @ormris should probably confirm, since they are the most familiar w/ the UnifiedLTO pipeline.
MaskRay
approved these changes
Sep 2, 2023
avillega
pushed a commit
to avillega/llvm-project
that referenced
this pull request
Sep 11, 2023
Some flags named "IsLTO" and "IsThinLTO" implied they described compilation modes, but with Unified LTO this is no longer true. Rename these to "PrepForXXX" to be less confusing to readers. Also, deleted "IsThinOrUnifiedLTO" because Unified implies PrepareForThinLTO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some flags named "IsLTO" and "IsThinLTO" implied they described compilation modes, but with Unified LTO this is no longer true. Rename these to "PrepForXXX" to be less confusing to readers. Also, deleted "IsThinOrUnifiedLTO" because Unified implies PrepareForThinLTO.