Skip to content

[MLIR][NFC] Mark barrier elimination helper static #65303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

sommerlukas
Copy link
Contributor

Make local helper functions static to avoid symbol name collision.

Make local helper functions static to avoid symbol name collision.
@sommerlukas sommerlukas requested a review from a team as a code owner September 5, 2023 07:30
@ftynse ftynse merged commit 06918a9 into llvm:main Sep 5, 2023
@sommerlukas sommerlukas deleted the mark-helpers-static branch September 5, 2023 07:59
@joker-eph
Copy link
Collaborator

Please do not use the "subscribers" teams as a "request review" facility. They aren't named "reviewer" intentionally

@sommerlukas
Copy link
Contributor Author

Please do not use the "subscribers" teams as a "request review" facility. They aren't named "reviewer" intentionally

I did not specify the reviewers at all, when creating the PR through the web-interface, it did not let me specify reviewers. I think the team was requested automatically, sorry for that. Maybe the setup can be improved?

@joker-eph
Copy link
Collaborator

OK: if you didn't specify it, it means that this how the tooling it setup, I didn't expect it would be done this way (especially since we have overlapping teams for codepaths), thanks for letting me know!

@ftynse
Copy link
Member

ftynse commented Sep 6, 2023

The "codeowners"-based tooling assigns the codeowner group if any of the owned files are touched. I think for issues we have a bot that posts a comment tagging the relevant group, which also sends an email/notification. This sounds preferable to pretending any subscriber is a code owner.

avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023
Make local helper functions static to avoid symbol name collision.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants