Skip to content

[NFC] Set a variable in the mlir data formatter #65554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

walter-erquinigo
Copy link
Member

The formatter fails when num_children is invoked and self.impl_type is not set.

The formatter fails when num_children is invoked and self.impl_type is not set.
@walter-erquinigo walter-erquinigo requested a review from a team as a code owner September 7, 2023 00:09
@github-actions github-actions bot added the mlir label Sep 7, 2023
@@ -5,6 +5,7 @@
"""

import re

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the empty line?

Copy link
Contributor

@River707 River707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please drop the empty line though, formatting weirdness?

@walter-erquinigo walter-erquinigo merged commit 9d10636 into llvm:main Sep 7, 2023
@walter-erquinigo walter-erquinigo deleted the walter/fix-none branch September 7, 2023 00:15
avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023
The formatter fails when num_children is invoked and self.impl_type is
not set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants