Skip to content

[clang][Interp] Diagnose uninitialized bases #67131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2023
Merged

[clang][Interp] Diagnose uninitialized bases #67131

merged 1 commit into from
Oct 3, 2023

Conversation

tbaederr
Copy link
Contributor

No description provided.

@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Sep 22, 2023
@tbaederr
Copy link
Contributor Author

tbaederr commented Oct 2, 2023

Ping

cor3ntin
cor3ntin approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@cor3ntin cor3ntin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should change the existing evaluator to be consistent? Otherwise LGTM

@tbaederr
Copy link
Contributor Author

tbaederr commented Oct 3, 2023

Maybe we should change the existing evaluator to be consistent? Otherwise LGTM

I'm not 100% sure what output is better, but we can change that later. This change is more about correctness.

@tbaederr tbaederr merged commit f58d54a into llvm:main Oct 3, 2023
Guzhu-AMD pushed a commit to GPUOpen-Drivers/llvm-project that referenced this pull request Oct 12, 2023
Merged main:f58d54ab969b into amd-gfx:25a5d3ddbc50
ec075f3 
Local branch amd-gfx 25a5d3d Merged main:0502d8347020 into amd-gfx:4191fabcf57f
Remote branch main f58d54a [clang][Interp] Diagnose uninitialized bases (llvm#67131)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cor3ntin cor3ntin cor3ntin approved these changes

Assignees
No one assigned
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbaederr @cor3ntin @llvmbot