Skip to content

[mlir] reword error message on unloaded dialect #67980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

ftynse
Copy link
Member

@ftynse ftynse commented Oct 2, 2023

The previous message was confusing as it mentioned "registration" but isn't in fact related to dialect registration. Use other words instead.

The previous message was confusing as it mentioned "registration" but
isn't in fact related to dialect registration. Use other words instead.
@ftynse ftynse requested a review from joker-eph October 2, 2023 12:43
@llvmbot llvmbot added mlir:core MLIR Core Infrastructure mlir labels Oct 2, 2023
@llvmbot
Copy link
Member

llvmbot commented Oct 2, 2023

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-core

Changes

The previous message was confusing as it mentioned "registration" but isn't in fact related to dialect registration. Use other words instead.


Full diff: https://github.com/llvm/llvm-project/pull/67980.diff

1 Files Affected:

  • (modified) mlir/include/mlir/IR/Builders.h (+2-2)
diff --git a/mlir/include/mlir/IR/Builders.h b/mlir/include/mlir/IR/Builders.h
index 3eca8bd12f43364..5e54d4ea49e8251 100644
--- a/mlir/include/mlir/IR/Builders.h
+++ b/mlir/include/mlir/IR/Builders.h
@@ -477,8 +477,8 @@ class OpBuilder : public Builder {
     if (LLVM_UNLIKELY(!opName)) {
       llvm::report_fatal_error(
           "Building op `" + OpT::getOperationName() +
-          "` but it isn't registered in this MLIRContext: the dialect may not "
-          "be loaded or this operation isn't registered by the dialect. See "
+          "` but it isn't known in this MLIRContext: the dialect may not "
+          "be loaded or this operation hasn't been added by the dialect. See "
           "also https://mlir.llvm.org/getting_started/Faq/"
           "#registered-loaded-dependent-whats-up-with-dialects-management");
     }

@ftynse ftynse merged commit f89b7a9 into llvm:main Oct 3, 2023
@ftynse ftynse deleted the rephrase branch October 3, 2023 09:28
Guzhu-AMD pushed a commit to GPUOpen-Drivers/llvm-project that referenced this pull request Oct 12, 2023
Local branch amd-gfx 2dc51f9 Merged main:853e126ce32a into amd-gfx:ec075f374ad2
Remote branch main f89b7a9 [mlir] reword error message on unloaded dialect (llvm#67980)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mlir:core MLIR Core Infrastructure mlir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants