[mlir][sparse] minor edits to support lib files #68137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeimingLiu
approved these changes
Oct 3, 2023
| /// Asserts: | ||
| /// * `dimRank` is nonzero. | ||
| /// * the elements of `dimSizes` are nonzero. | ||
| /// sizes and an optional initial storage capacity. |
There was a problem hiding this comment.
Maybe add "the size of the range pointed by dimSizes is determined by dimRank"?
| @@ -240,8 +238,7 @@ MLIR_CRUNNERUTILS_EXPORT index_type getSparseTensorReaderNSE(void *p); | |||
| MLIR_CRUNNERUTILS_EXPORT index_type getSparseTensorReaderDimSize(void *p, | |||
| index_type d); | |||
|
|
|||
| /// Releases the SparseTensorReader. This also closes the file associated with | |||
| /// the reader. | |||
| /// Releases the SparseTensorReaderand closes the associated file. | |||
There was a problem hiding this comment.
missing a space between Readerand
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
yinying-lisa-li
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.