[OCaml][test] Use correct data layout string. #68781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core.ml would previously set a data layout string of "e" and check that it remained "e". This is fragile when we have the data layout string auto-upgrade facility, and indeed broke when D86310 upgraded this one. As the auto-upgrade logic is not what is being tested here, it seems easier to just use the data layout string that the target expects.
nikic
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core.ml would previously set a data layout string of "e" and check that it remained "e". This is fragile when we have the data layout string auto-upgrade facility, and indeed broke when D86310 upgraded this one. As the auto-upgrade logic is not what is being tested here, it seems easier to just use the data layout string that the target expects.