[llvm-readtapi] Fix bad symlink with readtapi tool #68835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyndyishida
pushed a commit
to cyndyishida/llvm-project
that referenced
this pull request
Nov 15, 2023
The Clang-AIX-Wyvern-Dev buildbot is currently failing at the set directory permission due to a bad symlink caused by this [commit](https://github.ibm.com/compiler/llvm-project/commit/a54f31fabd55ab111484b1e094e3d2c6b29c4715). This change is creating the additional symlink `readtapi -> llvm-readtapi` which causes it to appear in `/buildbot_worker/official-worker/clang-aix-dev/installdir`. After some investigation, it looks like `readtapi` is the only tool that is getting symlinked that is not guarded by the `LLVM_INSTALL_BINUTILS_SYMLINKS` macro. For example: 1. `llvm/tools/llvm-objcopy/CMakeLists.txt` ``` if(LLVM_INSTALL_BINUTILS_SYMLINKS) add_llvm_tool_symlink(objcopy llvm-objcopy) endif() ``` 2. `llvm/tools/llvm-dwp/CMakeLists.txt` ``` if(LLVM_INSTALL_BINUTILS_SYMLINKS) add_llvm_tool_symlink(dwp llvm-dwp) endif() ```
cyndyishida
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Nov 16, 2023
The Clang-AIX-Wyvern-Dev buildbot is currently failing at the set directory permission due to a bad symlink caused by this [commit](https://github.ibm.com/compiler/llvm-project/commit/a54f31fabd55ab111484b1e094e3d2c6b29c4715). This change is creating the additional symlink `readtapi -> llvm-readtapi` which causes it to appear in `/buildbot_worker/official-worker/clang-aix-dev/installdir`. After some investigation, it looks like `readtapi` is the only tool that is getting symlinked that is not guarded by the `LLVM_INSTALL_BINUTILS_SYMLINKS` macro. For example: 1. `llvm/tools/llvm-objcopy/CMakeLists.txt` ``` if(LLVM_INSTALL_BINUTILS_SYMLINKS) add_llvm_tool_symlink(objcopy llvm-objcopy) endif() ``` 2. `llvm/tools/llvm-dwp/CMakeLists.txt` ``` if(LLVM_INSTALL_BINUTILS_SYMLINKS) add_llvm_tool_symlink(dwp llvm-dwp) endif() ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A buildbot is currently failing at the set directory permission due to a bad symlink caused by this commit. This change is creating the additional symlink
readtapi -> llvm-readtapiwhich causes it to appear in the install directory.After some investigation, it looks like
readtapiis the only tool that is getting symlinked that is not guarded by theLLVM_INSTALL_BINUTILS_SYMLINKSmacro. For example:llvm/tools/llvm-objcopy/CMakeLists.txtllvm/tools/llvm-dwp/CMakeLists.txt