Skip to content

[lldb][gardening] Remove full name of "DWARFDIE" type in GetTypeForDIE #70062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

augusto2112
Copy link
Contributor

When moving the GetTypeForDIE function from DWARFASTParserClang to DWARFASTParser, I kept the signature as-is. To match the rest of the function signatures in DWARFASTParser, remove the full name (lldb_private::plugin::dwarf::DWARFDIE -> DWARFDIE) in the signature of DWARFASTParser::GetTypeForDIE.

When moving the GetTypeForDIE function from DWARFASTParserClang to
DWARFASTParser, I kept the signature as-is. To match the rest of the
function signatures in DWARFASTParser, remove the full name
(lldb_private::plugin::dwarf::DWARFDIE -> DWARFDIE) in the signature
of DWARFASTParser::GetTypeForDIE.
@llvmbot
Copy link
Member

llvmbot commented Oct 24, 2023

@llvm/pr-subscribers-lldb

Author: Augusto Noronha (augusto2112)

Changes

When moving the GetTypeForDIE function from DWARFASTParserClang to DWARFASTParser, I kept the signature as-is. To match the rest of the function signatures in DWARFASTParser, remove the full name (lldb_private::plugin::dwarf::DWARFDIE -> DWARFDIE) in the signature of DWARFASTParser::GetTypeForDIE.


Full diff: https://github.com/llvm/llvm-project/pull/70062.diff

1 Files Affected:

  • (modified) lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h (+1-2)
diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h
index 6749cb0e5db17a6..66db396279e0630 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h
@@ -64,8 +64,7 @@ class DWARFASTParser {
   ParseChildArrayInfo(const DWARFDIE &parent_die,
                       const ExecutionContext *exe_ctx = nullptr);
 
-  lldb_private::Type *
-  GetTypeForDIE(const lldb_private::plugin::dwarf::DWARFDIE &die);
+  lldb_private::Type *GetTypeForDIE(const DWARFDIE &die);
 
   static lldb::AccessType GetAccessTypeFromDWARF(uint32_t dwarf_accessibility);
 

@augusto2112 augusto2112 merged commit e3476f6 into llvm:main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants