Skip to content

[BOLT] Fix address mapping for ICP code #70136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

maksfb
Copy link
Contributor

@maksfb maksfb commented Oct 24, 2023

When we create new code for indirect code promotion optimization, we should mark it as originating from the indirect jump instruction for BOLT address translation (BAT) to map it to the original instruction.

When we create new code for indirect code promotion optimization, we
should mark it as originating from the indirect jump instruction for
BOLT address translation (BAT) to map it to the original instruction.
Copy link
Contributor

@aaupov aaupov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to assign offsets to ICP-created jumps from indirect call/jmp (or from the containing block). This should fix the profile collected in BAT mode.

@maksfb maksfb added the BOLT label Nov 5, 2023
@maksfb maksfb merged commit 7f031d1 into llvm:main Nov 6, 2023
@maksfb maksfb deleted the gh-fix-icp branch November 6, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants