Skip to content

[BOLT] Deprecate hfsort+ in favor of cdsort #72408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2024
Merged

[BOLT] Deprecate hfsort+ in favor of cdsort #72408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions bolt/include/bolt/Passes/HFSort.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,10 @@
// Implementation of HFSort algorithm for function ordering:
// https://research.fb.com/wp-content/uploads/2017/01/cgo2017-hfsort-final1.pdf
//
// Cluster functions by hotness. There are four clustering algorithms:
// Cluster functions by hotness. There are three clustering algorithms:
// 1. clusterize
// 2. HFsort+
// 3. pettisAndHansen
// 4. randomClusters
// 2. pettisAndHansen
// 3. randomClusters
//
//===----------------------------------------------------------------------===//

Expand Down Expand Up @@ -81,11 +80,6 @@ inline bool compareClustersDensity(const Cluster &C1, const Cluster &C2) {
*/
std::vector<Cluster> clusterize(const CallGraph &Cg);

/*
* Optimize function placement prioritizing i-TLB and i-cache performance.
*/
std::vector<Cluster> hfsortPlus(CallGraph &Cg);

/*
* Pettis-Hansen code layout algorithm
* reference: K. Pettis and R. C. Hansen, "Profile Guided Code Positioning",
Expand Down
1 change: 0 additions & 1 deletion bolt/lib/Passes/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ add_llvm_library(LLVMBOLTPasses
FixRelaxationPass.cpp
FixRISCVCallsPass.cpp
HFSort.cpp
HFSortPlus.cpp
Hugify.cpp
IdenticalCodeFolding.cpp
IndirectCallPromotion.cpp
Expand Down
Loading