Skip to content

test-release.sh: Only build the clang target in stage 1 and 2 #72703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

tstellar
Copy link
Collaborator

This skips the build of all the unittests and llvm/clang tools, reducing the number of ninja targets from 4,826 to 3,816 in phase 1 and phase 2.

This skips the build of all the unittests and llvm/clang tools,
reducing the number of ninja targets from 4,826 to 3,816.
@tstellar tstellar requested a review from tru November 17, 2023 21:21
Copy link
Collaborator

@tru tru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But feels like a bit of Deja vu. Didn't we do this at some point already? Or something very similar at least.

@tstellar
Copy link
Collaborator Author

Your probably thinking of: 19f100e. This commit stopped building all the other projects like lld, lldb, etc., but it still was building with the default target which included tests, utilities and other things that aren't actually used in the later phases.

@tstellar tstellar merged commit 907ed77 into llvm:main Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants