Skip to content

[SystemZ][z/OS] Replace unconventional characters that are not within the ASCII range #72906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

abhina-sree
Copy link
Contributor

@abhina-sree abhina-sree commented Nov 20, 2023

This revision fixes the following error on z/OS.
LLVM ERROR: IO failure on output stream: EDC5122I Input/output error.

I replace unconventional characters with characters that are within the ASCII range.

@abhina-sree abhina-sree self-assigned this Nov 20, 2023
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Nov 20, 2023
@llvmbot
Copy link
Member

llvmbot commented Nov 20, 2023

@llvm/pr-subscribers-clang

Author: Abhina Sree (abhina-sree)

Changes

This revision fixes the following error on z/OS.
LLVM ERROR: IO failure on output stream: EDC5122I Input/output error.


Full diff: https://github.com/llvm/llvm-project/pull/72906.diff

1 Files Affected:

  • (modified) clang/include/clang/Basic/AttrDocs.td (+2-2)
diff --git a/clang/include/clang/Basic/AttrDocs.td b/clang/include/clang/Basic/AttrDocs.td
index 438d846c39eaa57..79e46fb7578b3c6 100644
--- a/clang/include/clang/Basic/AttrDocs.td
+++ b/clang/include/clang/Basic/AttrDocs.td
@@ -6701,7 +6701,7 @@ def ArmSmeStreamingCompatibleDocs : Documentation {
   let Category = DocCatArmSmeAttributes;
   let Content = [{
 The ``__arm_streaming_compatible`` keyword applies to prototyped function types and
-specifies that the function has a “streaming compatible interface”.  This
+specifies that the function has a "streaming compatible interface".  This
 means that:
 
 * the function may be entered in either non-streaming mode (PSTATE.SM=0) or
@@ -7495,7 +7495,7 @@ a **coroutine return type (CRT)**.
 
 A function ``R func(P1, .., PN)`` has a coroutine return type (CRT) ``R`` if ``R``
 is marked by ``[[clang::coro_return_type]]`` and  ``R`` has a promise type associated to it
-(i.e., std​::​coroutine_traits<R, P1, .., PN>​::​promise_type is a valid promise type).
+(i.e., std::coroutine_traits<R, P1, .., PN>::promise_type is a valid promise type).
 
 If the return type of a function is a ``CRT`` then the function must be a coroutine.
 Otherwise the program is invalid. It is allowed for a non-coroutine to return a ``CRT``

Copy link
Contributor

@perry-ca perry-ca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhina-sree abhina-sree changed the title [SystemZ][z/OS] Replace characters that are not supported by ASCII to EBCDIC conversion [SystemZ][z/OS] Replace unconventional characters that are not within the ASCII range Nov 21, 2023
@abhina-sree abhina-sree merged commit f4418f8 into llvm:main Nov 21, 2023
@abhina-sree abhina-sree deleted the abhina/fix_char branch November 21, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants