[PowerPC] Move __ehinfo TOC entries to the end of the TOC section #73586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandlebug
reviewed
Nov 29, 2023
| @@ -2459,6 +2459,7 @@ void PPCAIXAsmPrinter::emitTracebackTable() { | |||
| auto &Ctx = OutStreamer->getContext(); | |||
| MCSymbol *EHInfoSym = | |||
| TargetLoweringObjectFileXCOFF::getEHInfoTableSymbol(MF); | |||
| cast<MCSymbolXCOFF>(EHInfoSym)->setEHInfo(); | |||
There was a problem hiding this comment.
Should this be in getEHInfoTableSymbol instead?
mandlebug
reviewed
Dec 7, 2023
There was a problem hiding this comment.
Thanks for the updates. I think all we are missing is a test where we compile to an object file using the integrated assembler and then dump the symbol information to show the toc entries for any eh infos have the large code model storage mapping class. Once we have that I think the patch is ready to land.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On AIX, the __ehinfo toc-entry is never referenced directly using instructions, therefore we can allocate them with the TE storage mapping class to move them to the end of TOC.