[lldb][progress] Always report progress upon Progress object destruction #73605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows a final progress report upon the destruction of the `Progress` object to happen at all times as opposed to when the progress was not completed
|
@llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) ChangesThis commit allows a final progress report upon the destruction of the Full diff: https://github.com/llvm/llvm-project/pull/73605.diff 1 Files Affected:
diff --git a/lldb/source/Core/Progress.cpp b/lldb/source/Core/Progress.cpp
index 08be73f1470f349..eee4d3955154ba9 100644
--- a/lldb/source/Core/Progress.cpp
+++ b/lldb/source/Core/Progress.cpp
@@ -32,8 +32,8 @@ Progress::~Progress() {
std::lock_guard<std::mutex> guard(m_mutex);
if (!m_completed) {
m_completed = m_total;
- ReportProgress();
}
+ ReportProgress();
}
void Progress::Increment(uint64_t amount, std::string update) {
|
medismailben
approved these changes
Nov 28, 2023
lldb/source/Core/Progress.cpp
Outdated
Comment on lines
33
to
35
| if (!m_completed) { | ||
| m_completed = m_total; | ||
| ReportProgress(); | ||
| } |
There was a problem hiding this comment.
chelcassanova
added a commit
to chelcassanova/llvm-project
that referenced
this pull request
Nov 28, 2023
…ion (llvm#73605) This commit allows a final progress report upon the destruction of the `Progress` object to happen at all times as opposed to when the progress was not completed. (cherry picked from commit c846f8b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows a final progress report upon the destruction of the
Progressobject to happen at all times as opposed to when the progress was not completed.