[libc] remove spurious LIBC_INLINE

[nickdesaulniers]

This function is marked noinline; the inline keyword (or whatever LIBC_INLINE
resolves to) will have no effect.

[llvmbot]

@llvm/pr-subscribers-libc

Author: Nick Desaulniers (nickdesaulniers)

Changes

This function is marked noinline; the inline keyword (or whatever LIBC_INLINE
resolves to) will have no effect.

---

Full diff: https://github.com/llvm/llvm-project/pull/74505.diff

1 Files Affected:

• (modified) libc/src/__support/threads/linux/thread.cpp (+1-1)

diff --git a/libc/src/__support/threads/linux/thread.cpp b/libc/src/__support/threads/linux/thread.cpp
index 5c84266ee5d0e..fcf87cc587a50 100644
--- a/libc/src/__support/threads/linux/thread.cpp
+++ b/libc/src/__support/threads/linux/thread.cpp
@@ -176,7 +176,7 @@ cleanup_thread_resources(ThreadAttributes *attrib) {
 #endif
 }
 
-[[gnu::noinline]] LIBC_INLINE void start_thread() {
+[[gnu::noinline]] void start_thread() {
   auto *start_args = reinterpret_cast<StartArgs *>(get_start_args_addr());
   auto *attrib = start_args->thread_attrib;
   self.attrib = attrib;

[michaelrj-google]

LGTM, as far as I know the special LIBC_INLINE value is only relevant for header files.

[gchatelet]

Cross-posting FYI #73659 (comment).
At this point I'm unsure if LIBC_INLINE is the right name for this macro.