[mlir:python] Fail immediately if importing an initializer module raises ImportError #74595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImportError. If ImportError is raised, _site_initialize will fail because 'm' will be an unbound local. Just return False in this case and fail fast.
hawkinsp
changed the title
|
@llvm/pr-subscribers-mlir Author: Peter Hawkins (hawkinsp) ChangesIf ImportError is raised, _site_initialize will fail because 'm' will be an unbound local. Just return False in this case and fail fast. @stellaraccident @makslevental Full diff: https://github.com/llvm/llvm-project/pull/74595.diff 1 Files Affected:
diff --git a/mlir/python/mlir/_mlir_libs/__init__.py b/mlir/python/mlir/_mlir_libs/__init__.py
index 32f46d24cc739..98dbbc6adf9ce 100644
--- a/mlir/python/mlir/_mlir_libs/__init__.py
+++ b/mlir/python/mlir/_mlir_libs/__init__.py
@@ -94,6 +94,7 @@ def process_initializer_module(module_name):
"encountered otherwise and the MLIR Python API may not function."
)
logger.warning(message, exc_info=True)
+ return False
logger.debug("Initializing MLIR with module: %s", module_name)
if hasattr(m, "register_dialects"):
|
|
Thanks @hawkinsp - do you need me to merge? |
|
@makslevental yes please! I have no LLVM committer privileges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If ImportError is raised, _site_initialize will fail because 'm' will be an unbound local. Just return False in this case and fail fast.
@stellaraccident @makslevental