Skip to content

[MC] Reduce size of MCLEBFragment (NFC) #75050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Dec 11, 2023

This recovers more of the max-rss regression introduced by https://reviews.llvm.org/D157657.

Per http://llvm-compile-time-tracker.com/compare.php?from=dd32d26a37e22a3bce15ed8c21145b17ff5e1401&to=b4d4aba0dfbbe405f4da3494575434710f4ec9b9&stat=max-rss&linkStats=on this is an about 1.2% max-rss improvement for the LTO link stage with debuginfo.

This recovers more of the max-rss regression introduced by
https://reviews.llvm.org/D157657.
@nikic nikic requested review from MaskRay and topperc December 11, 2023 14:07
@MaskRay
Copy link
Member

MaskRay commented Dec 12, 2023

I suggested that we can try MCEncodedFragmentWithFixups<10, 1>, e.g. <8, 0> <8, 1> <10, 1>., perhaps we can just do <8. 0>

@nikic
Copy link
Contributor Author

nikic commented Dec 12, 2023

I suggested that we can try MCEncodedFragmentWithFixups<10, 1>, e.g. <8, 0> <8, 1> <10, 1>., perhaps we can just do <8. 0>

Yeah, I did try these separately first. For <10, 1> to <8, 1> we get -0.7% and for <8, 1> to <8, 0> we get -0.5%. So both changes seem worthwhile.

@nikic nikic merged commit 41aa0d4 into llvm:main Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants