Skip to content

[lldb] Skip 2 newly introduced tests from running on DWARF2 and clang 11 #75406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

augusto2112
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Dec 13, 2023

@llvm/pr-subscribers-lldb

Author: Augusto Noronha (augusto2112)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/75406.diff

2 Files Affected:

  • (modified) lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py (+1)
  • (modified) lldb/test/API/functionalities/location-list-lookup/TestLocationListLookup.py (+2-1)
diff --git a/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py b/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py
index 4e0f14d039a743..8c3bdabeaac1ba 100644
--- a/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py
+++ b/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py
@@ -19,6 +19,7 @@ def getFormatted(self, format, expr):
         self.assertTrue(result.Succeeded(), result.GetError())
         return result.GetOutput()
 
+    @skipIf(dwarf_version=["<", "3"])
     @no_debug_info_test
     @skipIfWindows
     def testAllPlatforms(self):
diff --git a/lldb/test/API/functionalities/location-list-lookup/TestLocationListLookup.py b/lldb/test/API/functionalities/location-list-lookup/TestLocationListLookup.py
index feea14ff355e82..c5f4a7c6dedc19 100644
--- a/lldb/test/API/functionalities/location-list-lookup/TestLocationListLookup.py
+++ b/lldb/test/API/functionalities/location-list-lookup/TestLocationListLookup.py
@@ -43,7 +43,8 @@ def test_loclist_frame_var(self):
         self.build()
         self.check_local_vars(self.launch(), check_expr=False)
 
-    @skipIf(compiler="clang", compiler_version=["<=", "11.0"])
+    @skipIf(dwarf_version=["<", "3"])
+    @skipIf(compiler="clang", compiler_version=["<", "12.0"])
     @skipUnlessDarwin
     def test_loclist_expr(self):
         self.build()

@adrian-prantl adrian-prantl merged commit b047c91 into llvm:main Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants