Fix what seems to be a silly bug in gpu.set_default_device rewriting. Smoke test included.

[pcf000]

No description provided.

[github-actions]

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

[llvmbot]

@llvm/pr-subscribers-mlir-gpu

@llvm/pr-subscribers-mlir

Author: Paul C Fuqua (pcf000)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/75756.diff

1 Files Affected:

• (modified) mlir/lib/Conversion/GPUCommon/GPUToLLVMConversion.cpp (+3-2)

diff --git a/mlir/lib/Conversion/GPUCommon/GPUToLLVMConversion.cpp b/mlir/lib/Conversion/GPUCommon/GPUToLLVMConversion.cpp
index b68baffb5a8565..94df3765a67e74 100644
--- a/mlir/lib/Conversion/GPUCommon/GPUToLLVMConversion.cpp
+++ b/mlir/lib/Conversion/GPUCommon/GPUToLLVMConversion.cpp
@@ -1334,8 +1334,9 @@ LogicalResult ConvertSetDefaultDeviceOpToGpuRuntimeCallPattern::matchAndRewrite(
     gpu::SetDefaultDeviceOp op, OpAdaptor adaptor,
     ConversionPatternRewriter &rewriter) const {
   Location loc = op.getLoc();
-  setDefaultDeviceCallBuilder.create(loc, rewriter, {adaptor.getDevIndex()});
-  rewriter.replaceOp(op, {});
+  auto call = setDefaultDeviceCallBuilder.create(loc, rewriter,
+                                                 {adaptor.getDevIndex()});
+  rewriter.replaceOp(op, call);
   return success();
 }
 

[pcf000]

@krzysz00

[joker-eph]

Thanks for the fix.
Can you provide a unit test for this?

also I’d look for a more descriptive title (and description)

[joker-eph]

@krzysz00 : I mentioned the need for fixing the title and description before merging, did you miss this?

[krzysz00]

@joker-eph Yeah, I did miss this, I just got pinged with an "it's been approved and you've got write access, can you merge"?

[pcf000]

I did fix them with a !amend commit, as the documentation seemed to tell me: the squash-and-merge was supposed to recognise that and update title and description.