[libunwind] Bump to CXX_STANDARD 17 #75986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libunwind uses C-style and low-level C++, so the language standard doesn't matter that much, but bumping to C++17 aligns with the rest of LLVM and enables some features that would cause pedantic warnings in C++11 (e.g. -Wc++17-attribute-extensions for [[fallthrough]]/ [[nodiscard]]/[[maybe_unused]]). (Contributors might use these features unaware of the pedantic warnings). Suggested-by: Christopher Di Bella <[email protected]>
|
@llvm/pr-subscribers-libunwind Author: Fangrui Song (MaskRay) Changeslibunwind uses C-style and low-level C++, so the language standard Suggested-by: Christopher Di Bella <[email protected]> Full diff: https://github.com/llvm/llvm-project/pull/75986.diff 1 Files Affected:
diff --git a/libunwind/src/CMakeLists.txt b/libunwind/src/CMakeLists.txt
index 570824260465d6..9c6f5d908b0945 100644
--- a/libunwind/src/CMakeLists.txt
+++ b/libunwind/src/CMakeLists.txt
@@ -154,7 +154,7 @@ target_link_libraries(unwind_shared_objects PUBLIC "${LIBUNWIND_ADDITIONAL_LIBRA
set_target_properties(unwind_shared_objects
PROPERTIES
CXX_EXTENSIONS OFF
- CXX_STANDARD 11
+ CXX_STANDARD 17
CXX_STANDARD_REQUIRED ON
COMPILE_FLAGS "${LIBUNWIND_COMPILE_FLAGS}"
)
@@ -194,7 +194,7 @@ target_link_libraries(unwind_static_objects PUBLIC "${LIBUNWIND_ADDITIONAL_LIBRA
set_target_properties(unwind_static_objects
PROPERTIES
CXX_EXTENSIONS OFF
- CXX_STANDARD 11
+ CXX_STANDARD 17
CXX_STANDARD_REQUIRED ON
COMPILE_FLAGS "${LIBUNWIND_COMPILE_FLAGS}"
)
|
compnerd
approved these changes
Dec 20, 2023
cjdb
approved these changes
Dec 20, 2023
cachemeifyoucan
added a commit
to cachemeifyoucan/llvm-project
that referenced
this pull request
Aug 30, 2024
Update swift interface hash test after change in: swiftlang/swift#75986
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libunwind uses C-style and low-level C++, so the language standard
doesn't matter that much, but bumping to C++17 aligns with the rest of
LLVM and enables some features that would cause pedantic warnings in
C++11 (e.g. -Wc++17-attribute-extensions for [[fallthrough]]/
[[nodiscard]]/[[maybe_unused]]). (Contributors might use these features
unaware of the pedantic warnings).
Suggested-by: Christopher Di Bella [email protected]