[LLDB] Fix write permission error in TestGlobalModuleCache.py

[cmtice]

TestGlobalModuleCache.py, a recently added test, tries to update a source file in the build directory, but it assumes the file is writable. In our distributed build and test system, this is not always true, so the test often fails with a write permissions error.

This change fixes that by setting the permissions on the file to be writable before attempting to write to it.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: None (cmtice)

Changes

TestGlobalModuleCache.py, a recently added test, tries to update a source file in the build directory, but it assumes the file is writable. In our distributed build and test system, this is not always true, so the test often fails with a write permissions error.

This change fixes that by setting the permissions on the file to be writable before attempting to write to it.

---

Full diff: https://github.com/llvm/llvm-project/pull/76171.diff

1 Files Affected:

• (modified) lldb/test/API/python_api/global_module_cache/TestGlobalModuleCache.py (+3)

diff --git a/lldb/test/API/python_api/global_module_cache/TestGlobalModuleCache.py b/lldb/test/API/python_api/global_module_cache/TestGlobalModuleCache.py
index 6bb22c46efb443..02b77310b0067b 100644
--- a/lldb/test/API/python_api/global_module_cache/TestGlobalModuleCache.py
+++ b/lldb/test/API/python_api/global_module_cache/TestGlobalModuleCache.py
@@ -26,6 +26,9 @@ def copy_to_main(self, src, dst):
         # a previous build, so sleep a bit here to ensure that the touch is later.
         time.sleep(2)
         try:
+            # Make sure dst is writeable before trying to write to it.
+            subprocess.run(['chmod', '777', dst], stdin=None,
+                           capture_output=False, encoding='utf-8')
             shutil.copy(src, dst)
         except:
             self.fail(f"Could not copy {src} to {dst}")

[github-actions]

✅ With the latest revision this PR passed the Python code formatter.

[rupprecht]

IIUC, the issue is that even though we are working in the build directory, which is writeable, we are copying a file from the source tree, which may be readonly, and those readonly permission bits persist when they're copied to the build directory.