Skip to content

[Flang] Clean up LoopVersioning LLVM_DEBUG blocks. NFC #77818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2024
Merged

[Flang] Clean up LoopVersioning LLVM_DEBUG blocks. NFC #77818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 32 additions & 38 deletions flang/lib/Optimizer/Transforms/LoopVersioning.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,26 +105,24 @@ struct ArgsUsageInLoop {
// Debug dump of the structure members assuming that
// the information has been collected for the given loop.
void dump(fir::DoLoopOp loop) const {
// clang-format off
LLVM_DEBUG(
mlir::OpPrintingFlags printFlags;
printFlags.skipRegions();
llvm::dbgs() << "Arguments usage info for loop:\n";
loop.print(llvm::dbgs(), printFlags);
llvm::dbgs() << "\nUsed args:\n";
for (auto &use : usageInfo) {
mlir::Value v = use.first;
v.print(llvm::dbgs(), printFlags);
llvm::dbgs() << "\n";
}
llvm::dbgs() << "\nCannot transform args:\n";
for (mlir::Value arg : cannotTransform) {
arg.print(llvm::dbgs(), printFlags);
llvm::dbgs() << "\n";
}
llvm::dbgs() << "====\n"
);
// clang-format on
LLVM_DEBUG({
mlir::OpPrintingFlags printFlags;
printFlags.skipRegions();
llvm::dbgs() << "Arguments usage info for loop:\n";
loop.print(llvm::dbgs(), printFlags);
llvm::dbgs() << "\nUsed args:\n";
for (auto &use : usageInfo) {
mlir::Value v = use.first;
v.print(llvm::dbgs(), printFlags);
llvm::dbgs() << "\n";
}
llvm::dbgs() << "\nCannot transform args:\n";
for (mlir::Value arg : cannotTransform) {
arg.print(llvm::dbgs(), printFlags);
llvm::dbgs() << "\n";
}
llvm::dbgs() << "====\n";
});
}

// Erase usageInfo and cannotTransform entries for a set
Expand Down Expand Up @@ -344,15 +342,13 @@ void LoopVersioningPass::runOnOperation() {
});

// Dump loops info after initial collection.
// clang-format off
LLVM_DEBUG(
llvm::dbgs() << "Initial usage info:\n";
for (fir::DoLoopOp loop : originalLoops) {
auto &argsInLoop = argsInLoops[loop];
argsInLoop.dump(loop);
}
);
// clang-format on
LLVM_DEBUG({
llvm::dbgs() << "Initial usage info:\n";
for (fir::DoLoopOp loop : originalLoops) {
auto &argsInLoop = argsInLoops[loop];
argsInLoop.dump(loop);
}
});

// Clear argument usage for parent loops if an inner loop
// contains a non-transformable usage.
Expand Down Expand Up @@ -382,15 +378,13 @@ void LoopVersioningPass::runOnOperation() {
});
}

// clang-format off
LLVM_DEBUG(
llvm::dbgs() << "Final usage info:\n";
for (fir::DoLoopOp loop : originalLoops) {
auto &argsInLoop = argsInLoops[loop];
argsInLoop.dump(loop);
}
);
// clang-format on
LLVM_DEBUG({
llvm::dbgs() << "Final usage info:\n";
for (fir::DoLoopOp loop : originalLoops) {
auto &argsInLoop = argsInLoops[loop];
argsInLoop.dump(loop);
}
});

// Reduce the collected information to a list of loops
// with attached arguments usage information.
Expand Down