Skip to content

Reland [mlir][ExecutionEngine] Add support for global constructors and destructors #78070 #78170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Reland [mlir][ExecutionEngine] Add support for global constructors and destructors #78070 #78170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a72a40a
[mlir][ExecutionEngine] Add support for global constructors and destr…
fabianmcg Jan 13, 2024
07ec461
add unsupported AArch64
fabianmcg Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions mlir/lib/ExecutionEngine/ExecutionEngine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,11 @@ ExecutionEngine::ExecutionEngine(bool enableObjectDump,
}

ExecutionEngine::~ExecutionEngine() {
// Execute the global destructors from the module being processed.
// TODO: Allow JIT deinitialize for AArch64. Currently there's a bug causing a
// crash for AArch64 see related issue #71963.
if (jit && !jit->getTargetTriple().isAArch64())
llvm::consumeError(jit->deinitialize(jit->getMainJITDylib()));
// Run all dynamic library destroy callbacks to prepare for the shutdown.
for (LibraryDestroyFn destroy : destroyFns)
destroy();
Expand Down Expand Up @@ -396,6 +401,12 @@ ExecutionEngine::create(Operation *m, const ExecutionEngineOptions &options,
};
engine->registerSymbols(runtimeSymbolMap);

// Execute the global constructors from the module being processed.
// TODO: Allow JIT initialize for AArch64. Currently there's a bug causing a
// crash for AArch64 see related issue #71963.
if (!engine->jit->getTargetTriple().isAArch64())
cantFail(engine->jit->initialize(engine->jit->getMainJITDylib()));

return std::move(engine);
}

Expand Down
33 changes: 33 additions & 0 deletions mlir/test/mlir-cpu-runner/global-constructors.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
// UNSUPPORTED: target=aarch64{{.*}}
// RUN: mlir-cpu-runner %s -e entry -entry-point-result=void \
// RUN: -shared-libs=%mlir_c_runner_utils | \
// RUN: FileCheck %s

// Test that the `ctor` executes before `entry` and that `dtor` executes last.
module {
llvm.func @printNewline()
llvm.func @printI64(i64)
llvm.mlir.global_ctors {ctors = [@ctor], priorities = [0 : i32]}
llvm.mlir.global_dtors {dtors = [@dtor], priorities = [0 : i32]}
llvm.func @ctor() {
%0 = llvm.mlir.constant(1 : i64) : i64
llvm.call @printI64(%0) : (i64) -> ()
llvm.call @printNewline() : () -> ()
// CHECK: 1
llvm.return
}
llvm.func @entry() {
%0 = llvm.mlir.constant(2 : i64) : i64
llvm.call @printI64(%0) : (i64) -> ()
llvm.call @printNewline() : () -> ()
// CHECK: 2
llvm.return
}
llvm.func @dtor() {
%0 = llvm.mlir.constant(3 : i64) : i64
llvm.call @printI64(%0) : (i64) -> ()
llvm.call @printNewline() : () -> ()
// CHECK: 3
llvm.return
}
}