[libc++] Remove a duplicated definition of _LIBCPP_NOINLINE #79114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I failed to delete the old definition as a part of llvm#73838.
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Dmitri Gribenko (gribozavr) ChangesI failed to delete the old definition as a part of #73838. Full diff: https://github.com/llvm/llvm-project/pull/79114.diff 1 Files Affected:
diff --git a/libcxx/include/__config b/libcxx/include/__config
index eab37e7576bdc3e..9557e8e8cf97f28 100644
--- a/libcxx/include/__config
+++ b/libcxx/include/__config
@@ -1235,12 +1235,6 @@ __sanitizer_verify_double_ended_contiguous_container(const void*, const void*, c
# define _LIBCPP_CONSTINIT
# endif
-# if __has_attribute(__noinline__)
-# define _LIBCPP_NOINLINE __attribute__((__noinline__))
-# else
-# define _LIBCPP_NOINLINE
-# endif
-
# if defined(__CUDACC__) || defined(__CUDA_ARCH__) || defined(__CUDA_LIBDEVICE__)
// The CUDA SDK contains an unfortunate definition for the __noinline__ macro,
// which breaks the regular __attribute__((__noinline__)) syntax. Therefore,
|
philnik777
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I failed to delete the old definition as a part of #73838.