Skip to content

[mlir] Fix debug output for passes that modify top-level operation. #80022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2024
Merged

[mlir] Fix debug output for passes that modify top-level operation. #80022

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ecf2c4
[mlir] Fix debug output for passes that modify top-level operation.
Jezurko Jan 30, 2024
56f280c
Make it so that the old behaviour is preserved more generally
Jezurko Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion mlir/lib/Rewrite/PatternApplicator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,11 @@ static void logImpossibleToMatch(const Pattern &pattern) {

/// Log IR after pattern application.
static Operation *getDumpRootOp(Operation *op) {
return op->getParentWithTrait<mlir::OpTrait::IsIsolatedFromAbove>();
Operation *isolatedParent =
op->getParentWithTrait<mlir::OpTrait::IsIsolatedFromAbove>();
if (isolatedParent)
return isolatedParent;
return op;
}
static void logSucessfulPatternApplication(Operation *op) {
llvm::dbgs() << "// *** IR Dump After Pattern Application ***\n";
Expand Down