Skip to content

[BOLT] support AArch64 JUMP26 createRelocation #83531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

linsinan1995
Copy link
Member

Add R_AARCH64_JUMP26 implementation for createRelocation, which could significantly reduce the number of failed scan-refs cases if we perform bolt on a selective range of functions. The implementation is based on CALL26 createRelocation.

// 12: b func2
// 16: func2

char Data[20] = {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is failing, probably due to using stack array here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, updated.

@linsinan1995 linsinan1995 force-pushed the add-jump26-createReloc branch from 981f308 to ff39b07 Compare March 4, 2024 06:26
// 12: b func2
// 16: func2

uint64_t Size = 20;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const or constexpr

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, thx.

Add R_AARCH64_JUMP26 implementation for createRelocation, which
could significantly reduce the number of failed scan-refs cases.
@linsinan1995 linsinan1995 force-pushed the add-jump26-createReloc branch from ff39b07 to 78ec69f Compare March 4, 2024 07:10
Copy link
Member

@yota9 yota9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@linsinan1995 linsinan1995 merged commit 71c2a13 into llvm:main Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants