Skip to content

[test] Move pr73894.ll to AArch64 directory and update the target triple #84269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

mcinally
Copy link
Contributor

@mcinally mcinally commented Mar 7, 2024

pr73894.ll is failing on a number of non-AArch64 buildbots. I'm not certain that this is a proper fix, but I think it's best to move the test to the test/Transforms/LoopVectorize/AArch64/ directory and replace the triple with one commonly used in that directory.

#73894

pr73894.ll is failing on a number of non-AArch64 buildbots. I'm
not certain that this is a proper fix, but I think it's best to
move the test to the test/Transforms/LoopVectorize/AArch64/
directory and replace the triple with one commonly used in that
directory.

llvm#73894
@mcinally mcinally requested a review from dyung March 7, 2024 01:37
@llvmbot
Copy link
Member

llvmbot commented Mar 7, 2024

@llvm/pr-subscribers-llvm-transforms

Author: Cameron McInally (mcinally)

Changes

pr73894.ll is failing on a number of non-AArch64 buildbots. I'm not certain that this is a proper fix, but I think it's best to move the test to the test/Transforms/LoopVectorize/AArch64/ directory and replace the triple with one commonly used in that directory.

llvm#73894


Full diff: https://github.com/llvm/llvm-project/pull/84269.diff

1 Files Affected:

  • (renamed) llvm/test/Transforms/LoopVectorize/AArch64/pr73894.ll (+1-1)
diff --git a/llvm/test/Transforms/LoopVectorize/pr73894.ll b/llvm/test/Transforms/LoopVectorize/AArch64/pr73894.ll
similarity index 99%
rename from llvm/test/Transforms/LoopVectorize/pr73894.ll
rename to llvm/test/Transforms/LoopVectorize/AArch64/pr73894.ll
index 4203a8eb8df6ea..1970ac966535db 100644
--- a/llvm/test/Transforms/LoopVectorize/pr73894.ll
+++ b/llvm/test/Transforms/LoopVectorize/AArch64/pr73894.ll
@@ -1,7 +1,7 @@
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 4
 ; RUN: opt -passes=loop-vectorize -mcpu=neoverse-v1 -force-vector-interleave=2 -force-vector-width=1 -S %s | FileCheck %s
 
-target triple = "arm64-linux"
+target triple = "aarch64-unknown-linux-gnu"
 
 define i32 @pr70988() {
 ; CHECK-LABEL: define i32 @pr70988(

Copy link
Collaborator

@dyung dyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a test that works on more architectures since I believe your original change does affect more than AArch64. But this is good enough for now to unblock the build bots, so lgtm.

@mcinally mcinally merged commit 416debf into llvm:main Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants